appDisplay: Fix focus path when edit is enabled

When an app folder is open and its panel is shown, there are
three main elements: the folder name, the list of apps, and the
Edit togglebutton. By default, the user can use TAB to jump
between the app icons and the Edit togglebutton, but when the
togglebutton is checked, the folder name becomes editable and
the focus jumps to it.

Unfortunately, if the user goes out of the editable name with
TAB, the focus only cycles between the Edit togglebutton and
the app icons, never landing over the editable folder name (which
remains editable until the Edit togglebutton is unchecked).

This patch fixed this, making the editable folder name focusable
when using TAB, as expected, when the Edit togglebutton is
checked.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4116>
(cherry picked from commit e19ee787a37dc6e5b71485d2eab3109da62fe290)

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 83169cdf301f9393c8073aa9e1df83afd888109e..2699e94d8c1ed0fb57f17ef6ef34411f81d2594f 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2604,13 +2604,14 @@ export const AppFolderDialog = GObject.registerClass({
     }
 
     _switchActor(from, to) {
-        to.reactive = true;
+        to.reactive = to.can_focus = true;
         to.ease({
             opacity: 255,
             duration: 300,
             mode: Clutter.AnimationMode.EASE_OUT_QUAD,
         });
 
+        from.can_focus = false;
         from.ease({
             opacity: 0,
             duration: 300,